dfaure added a comment.
In D29871#676150 <https://phabricator.kde.org/D29871#676150>, @rrosch wrote: > I didn't have an assert before though, should I replace the if statement with a Q_ASSERT then? Yes I still believe you should. > I thought that was just to catch errors Yes, it is. If everything works as intended, this method will never be called with canToggleShowHiddenFolders == false. And `if()` makes people think that it can, which is just not true. > but since this is just an option What is an option? > (and hence shouldn't cause problems when false) Confusing code is a problem. > For the doc, I thought you were saying that since in Windows you have hidden folders without the dot that it was ok to remove that part. I don't see where I said that. On the contrary, I said this was working the same on all platforms, Windows included. There are some special cases for 3 protocols, but that's too much detail. Still the 99% rule is "starts with a dot". REPOSITORY R226 Konqueror REVISION DETAIL https://phabricator.kde.org/D29871 To: rrosch, dfaure Cc: kde-doc-english, gennad, fbampaloukas, skadinna
