----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105862/ -----------------------------------------------------------
(Updated Aug. 5, 2012, 9:28 a.m.) Review request for KDE Frameworks and David Faure. Changes ------- If it works, ship it :) Thanks for your attempts at building invididual frameworks standalone. This particular issue is probably a side effect of moving QtMimeTypes into libinqt5, it was separate initially. (Maybe an option would be to only consider this with a Qt5 build though, then libinqt5 isn't needed at all. I want to keep Qt4 compat for the current work of moving stuff around and cutting internal dependencies, but for building the frameworks standalone, maybe we can say only qt5 is supported... well, unless you'd rather work on this with qt4.) Description ------- I hope this is the correct fix - it makes it possible to include files from QtMimeTypes after it has been installed when building individual frameworks standalone, and the includes are still in include/inqt5/QtMimeTypes so I don't think there's any new risk of conflict with Qt upstream instroduced. Is this OK? Diffs ----- libinqt5/src/libqtmimetypes/CMakeLists.txt 80b48879d1b52bee02acbdae7bee22b82cb68940 Diff: http://git.reviewboard.kde.org/r/105862/diff/ Testing ------- Thanks, George Goldberg
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
