Alexander Neundorf wrote: > The code for creating a Config.cmake file is not trivial, but IMO also not > boilerplate, and Stephen agreed in Berlin that this will have to be done > individually be every project. This is the added > threadweaverConfig.cmake.in and the call to > configure_package_config_file() in the CMakeLists.txt.
Yes, I agree that the macro you'd proposed before was too large and 'generic' and that it would probably be easier to create separate config files per-framework. However, I also think that many KDE frameworks might benefit from having a much less complex macro so that the 'trivial' cases are easy to handle with a macro (eg, KDE Frameworks which only install a library, and no plugins or macros or do anything else 'funny'). That is something that can be investigated at any time though, and probably only when we have some information about all frameworks we're going to start with. I don't think 'get one framework buildsystem correct/complete and then try to apply it to all other frameworks' is the right way to go. Rather, I think 'Let's get things working in some form, then see where we can extract common stuff to macros or upstream CMake' is the right way to go. I think that's what we've been doing so far. > > The Config.cmake file may contain project-specific information, it must > take care of finding dependencies, it may include macro-files, etc. Trying > to wrap that in a macro will IMO not make it easier to work with. Thanks, Steve. _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
