Alexander Neundorf wrote:
> Please have a look at the current solidConfig.cmake.in.
> This is mostly as I think it should be (the include-guard is still
> missing).
>
> solidConfig.cmake
> # solidConfig.cmake provides information about the installed solid
> # library.
> #is supported solid_HAVE_UDev - TRUE if device discovery via udev
> #is supported solid_USE_UDisk2 - TRUE is udisk2 is used instead of
> #udisk on UNIX systems
Why HAVE vs USE? It looks like USE_SYSTEM_UDisks2 would be appropriate?
Do any of these 'feature variables' affect the headers of solid? For example
with #defines?
> set(solid_INSTALL_PREFIX "${PACKAGE_PREFIX_DIR}")
I still don't consider this useful in general.
> set(solid_LIBRARY KF5::solid) # is this one needed ?
No, I don't see why it would be.
Thanks,
Steve.
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
