----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107687/ -----------------------------------------------------------
(Updated Jan. 8, 2013, 3:40 p.m.) Review request for KDE Frameworks. Changes ------- Rebased the series on top of review #108263 Un-deprecated and un-inlined daysInWeek, but still centralized its implementation. That way we get most of the code simplifications without making future changes impossible. Description (updated) ------- All calendar systems supported by KCalendarSystem have 7 days per week, so simplify some code by centralizing that figure. Diffs (updated) ----- kdecore/date/kcalendarsystem.h efddd08 kdecore/date/kcalendarsystem.cpp 198a863 kdecore/date/kcalendarsystemcoptic.cpp 43d2611 kdecore/date/kcalendarsystemcopticprivate_p.h 35907ff kdecore/date/kcalendarsystemgregorian.cpp 663cd1b kdecore/date/kcalendarsystemgregorianprivate_p.h fb7a0dd kdecore/date/kcalendarsystemhebrew.cpp fd66fa2 kdecore/date/kcalendarsystemindiannational.cpp 2cbfe23 kdecore/date/kcalendarsystemislamiccivil.cpp 774e081 kdecore/date/kcalendarsystemjalali.cpp 486ef16 kdecore/date/kcalendarsystemjulian.cpp 23988e8 kdecore/date/kcalendarsystemprivate_p.h d935ead kdecore/date/kdatetimeparser.cpp a416808 Diff: http://git.reviewboard.kde.org/r/107687/diff/ Testing ------- Thanks, Jon Severinsson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
