----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25788 -----------------------------------------------------------
kdecore/util/kuser_unix.cpp <http://git.reviewboard.kde.org/r/108389/#comment19706> i don't think it's actually useful to check the euid. HOME is supposed to match the real uid, and setuid programs better make sure that this holds true (not that setuid with kde libs would be particularly good idea to start with). if you are concerned about the extra getuid calls, you could pass this in an (optional) parameter. - Oswald Buddenhagen On Jan. 19, 2013, 10:52 a.m., Jon Severinsson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108389/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2013, 10:52 a.m.) > > > Review request for KDE Frameworks and Oswald Buddenhagen. > > > Description > ------- > > This turns KUser::homeDir (and thus KShell::tildeExpand) closer to > QDir::homePath, which only consults the environment variable. > > It will therefore also fix the kdecore-kshelltest test when HOME is set to a > different directory. > > > Diffs > ----- > > kdecore/util/kuser_unix.cpp 6a612a6 > > Diff: http://git.reviewboard.kde.org/r/108389/diff/ > > > Testing > ------- > > > Thanks, > > Jon Severinsson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
