> On Feb. 6, 2013, 11:14 p.m., Albert Astals Cid wrote: > > Has this been committed? It has Ship It! but still shows open in > > reviewboard.
I'm currently having almost no time, I'd be grateful if someone commits it on behalf of me. - Andrius da Costa ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/#review26802 ----------------------------------------------------------- On Aug. 5, 2012, 10:28 p.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105868/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2012, 10:28 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Description > ------- > > Q_OS_WIN & Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE. > > > Diffs > ----- > > kde3support/KDE3SupportMacros.cmake a4f44e2 > kdecore/CMakeLists.txt e5cbd19 > kded/CMakeLists.txt fb204e8 > kdeui/CMakeLists.txt 7849b52 > kdeui/KDEUIMacros.cmake d5c20d9 > kinit/CMakeLists.txt 3c283a6 > tier1/kidletime/src/CMakeLists.txt 973d623 > tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd > > Diff: http://git.reviewboard.kde.org/r/105868/diff/ > > > Testing > ------- > > Got undefined references before the fix. > > > Thanks, > > Andrius da Costa Ribas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
