On Tue, Apr 02, 2013 at 03:46:52PM +0200, Chusslove Illich wrote: > After considering comments from the previous iteration: > > http://mail.kde.org/pipermail/kde-frameworks-devel/2012-December/001358.html > > here is the updated version: > just a quick scan of the diffs from me:
the .h file postprocessing in \subsubsection link_ui is a gross hack, and i don't see any plausible reason why this should not be fixed in uic instead. both the api and the docs still refer to catalogs in many places. while it may make sense to keep talking about catalogs when referring specifically to files, i have the impression that the use is not entirely consistent. + * Instructions for building the configuration code from [a] \c .kcfg file style issues: - in all your function prototypes/definitions, you are putting a space after the function name - in else constructs you are not attaching the else to the closing brace _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel