----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107696/#review32124 -----------------------------------------------------------
Jon, AFAICT this patch hasn't been pushed and it's been way more than a week. Any reason why you didn't push after all? - Kevin Ottens On Jan. 19, 2013, 12:41 p.m., Jon Severinsson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107696/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2013, 12:41 p.m.) > > > Review request for KDE Frameworks, David Faure and John Layt. > > > Description > ------- > > Weekday names depend on *language*, not calendar system. The usual ki18nc can > handle it just fine, so consolidate it all to a single function. > > Note: Before this patch I'm moving some functions to a new file > "kcalendarsystemweek.cpp" in order move to out of the way of regular calendar > system code. That commit changes no code whatsoever, so don't really need a > review. > > > Diffs > ----- > > kdecore/date/kcalendarsystem.h c121bb6 > kdecore/date/kcalendarsystem.cpp 35877b7 > kdecore/date/kcalendarsystemcoptic.cpp 86d35a9 > kdecore/date/kcalendarsystemcoptic_p.h 5287271 > kdecore/date/kcalendarsystemcopticprivate_p.h 8ceb5ad > kdecore/date/kcalendarsystemethiopian.cpp 9bfc41f > kdecore/date/kcalendarsystemethiopian_p.h 4f8119e > kdecore/date/kcalendarsystemgregorian.cpp 18b7aef > kdecore/date/kcalendarsystemgregorian_p.h 8890643 > kdecore/date/kcalendarsystemgregorianprivate_p.h 1208fe9 > kdecore/date/kcalendarsystemhebrew.cpp 660cb6d > kdecore/date/kcalendarsystemhebrew_p.h 132e21f > kdecore/date/kcalendarsystemindiannational.cpp 7c4fe03 > kdecore/date/kcalendarsystemindiannational_p.h 499d2fa > kdecore/date/kcalendarsystemislamiccivil.cpp abca3b5 > kdecore/date/kcalendarsystemislamiccivil_p.h 6d4682f > kdecore/date/kcalendarsystemjalali.cpp 331f2b3 > kdecore/date/kcalendarsystemjalali_p.h c88d304 > kdecore/date/kcalendarsystemjapanese.cpp d8a870b > kdecore/date/kcalendarsystemjapanese_p.h 09bb4f4 > kdecore/date/kcalendarsystemjulian.cpp d1b5864 > kdecore/date/kcalendarsystemjulian_p.h 5940c27 > kdecore/date/kcalendarsystemminguo.cpp 165c86f > kdecore/date/kcalendarsystemminguo_p.h 0a3b5d7 > kdecore/date/kcalendarsystemprivate_p.h 43b486f > kdecore/date/kcalendarsystemweek.cpp PRE-CREATION > kdecore/tests/kcalendartest.h ea5b836 > kdecore/tests/kcalendartest.cpp 5c4d438 > > Diff: http://git.reviewboard.kde.org/r/107696/diff/ > > > Testing > ------- > > `make test` shows no regressions > > > Thanks, > > Jon Severinsson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel