On Thursday 16 May 2013 08:13:55 David Edmundson wrote: > KConfigDialogManager currently contains a map of every possible widget > along with the name of the signal to connect to to know when a widget > changes. > > Can we kill this entire map and replace it with monitoring > widget->metaObject()->userProperty()->notifySignal() at runtime? > It will greatly simplify the code in there, whilst also making it more > extensible/flexible/future proof.
I'm not sure I understand what you are after. userProperty() is already used at some places (ok, not its notifySignal()). As Albert mention even if we use it more (likely a good thing as you point out), we'd still need the map as we're not always monitoring the user property (most notably for QComboBox indeed). So I agree a patch would be interesting, I doubt we can completely remove that map though. :-) Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
