> On June 11, 2013, 9:01 a.m., Kevin Ottens wrote: > > kioslave/http/http.cpp, line 4668 > > <http://git.reviewboard.kde.org/r/110945/diff/1/?file=149512#file149512line4668> > > > > It's a QDataStream so we could use a QDateTime in there (would require > > adjusting deserialize too... means we can get rid of readTime() completely). > > > > David, any opinion for such an adjustment?
Which David are you asking for opinion? Me, David Faure or David Edmundson? Every now and then a new David is growing over here... ;-) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110945/#review34110 ----------------------------------------------------------- On June 10, 2013, 9:50 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110945/ > ----------------------------------------------------------- > > (Updated June 10, 2013, 9:50 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port time_t to QDateTime in HTTP (KIOSLAVE) > > --Fix some warnings about parentheses in conditionals. > --Delete some includes that apparently weren't used. > > TODO: > --Port QRegExp to QRegularExpression > --Port QLatin1String to QStringLiteral where needed > > > Diffs > ----- > > kioslave/http/http.h b16254ec815106c63f4b73ea4a13a9bc4a393a71 > kioslave/http/http.cpp c7b7c03991d26ade0b85615a3a798b479a5bbc1f > > Diff: http://git.reviewboard.kde.org/r/110945/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
