----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110957/ -----------------------------------------------------------
Review request for KDE Frameworks. Description ------- Fix compilation with clang Not sure about the kgenericfactory.h change, though: it converts QString -> Utf8 -> QString. Maybe add another constructor to KPluginFactory that takes two QStrings? Diffs ----- kdeui/tests/kcolorbuttontest.cpp 81e659f78199ffe98d6f0b6a9b46506e11a999a2 staging/kde4support/src/kdecore/kgenericfactory.h 6e9279e8b0d543a1edd8e948b21284e37dbe5a83 tier1/threadweaver/benchmarks/QueueBenchmarks.cpp 9324f641612f8c9536b01ff2befb3d9d9fb12c75 Diff: http://git.reviewboard.kde.org/r/110957/diff/ Testing ------- compiles now Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
