----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111105/#review34647 -----------------------------------------------------------
kdeui/util/kwallet.h <http://git.reviewboard.kde.org/r/111105/#comment25443> Turns out that line is not necessary. If you could remove it since you're at it. Thanks. staging/kwallet/src/CMakeLists.txt <http://git.reviewboard.kde.org/r/111105/#comment25442> Are they all public? It looks like only Qt5::Widgets is, the other ones could go in a LINK_PRIVATE line AFAICT. That would give: target_link_libraries(KWallet LINK_PUBLIC Qt5::Widgets) target_link_libraries(KWallet LINK_PRIVATE Qt5::DBus ${KWindowSystem_LIBRARIES} KConfigCore) Also why ${KWindowSystem_LIBRARIES} and not simply KWindowSystem. It should work just like KConfigCore, it not let us know, that would be a bug. - Kevin Ottens On June 18, 2013, 10:38 p.m., Wojciech Kapuscinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111105/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 10:38 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > Create KWallet framework and move kwallet.h and others. > > Notes: > Port aways from kdebug > remove unused includes > > > Diffs > ----- > > kdeui/CMakeLists.txt 0f2a0a9 > kdeui/tests/CMakeLists.txt 482581c > kdeui/tests/kwallettest.h > kdeui/tests/kwallettest.cpp 7a91a29 > kdeui/util/config-kwallet.h.cmake > kdeui/util/kwallet.h eb46a89 > kdeui/util/kwallet.cpp 7016b51 > kdeui/util/kwallet_mac.cpp ce09f93 > kdeui/util/org.kde.KWallet.xml > kdewebkit/CMakeLists.txt 93a44e9 > khtml/CMakeLists.txt 010eb95 > kio/CMakeLists.txt a29905e > staging/CMakeLists.txt 4e4132b > staging/kwallet/CMakeLists.txt PRE-CREATION > staging/kwallet/KWalletConfig.cmake.in PRE-CREATION > staging/kwallet/autotests/CMakeLists.txt PRE-CREATION > staging/kwallet/src/CMakeLists.txt PRE-CREATION > staging/kwallet/tests/CMakeLists.txt PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111105/diff/ > > > Testing > ------- > > It builds on Linux. > > > Thanks, > > Wojciech Kapuscinski > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
