----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111184/#review35019 -----------------------------------------------------------
Please also mark the feature on KLineEdit deprecated in that patch. kio/kfile/kurlrequester.cpp <http://git.reviewboard.kde.org/r/111184/#comment25631> Why don't you use KUrlMimeData like the original code in KLineEdit? It'll be more robust AFAICT. kio/kfile/kurlrequester.cpp <http://git.reviewboard.kde.org/r/111184/#comment25632> Probably better to make that d->combo->lineEdit() == obj - Kevin Ottens On June 24, 2013, 10:15 p.m., Albert Vaca Cintora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111184/ > ----------------------------------------------------------- > > (Updated June 24, 2013, 10:15 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > KLineEdit and KComboBox had the property enableUrlDrops that was added to use > it in KUrlRequester. Since KUrlRequester is part of KIO, it can not use > Kde4Support and should be ported to use QLineEdit and QComboBox. As I said on > my email to the frameworks list, it was easier to implement this directly in > KUrlRequester than patching Qt, even though it was originally planned as a Qt > task. It was my intention to also remove that property from KLineEdit and > KComboBox, but finally I didn't include it in the patch (see Ervin's comment > in the mailing list). > > In the patch I have also added a TODO because I think it would be good to > detect any url without needing the mimetype to be set, but I have not done it > yet because it should be discussed first. > > (Reviewed by aacid and apol) > > > Diffs > ----- > > kio/kfile/kurlrequester.cpp fa6b234 > > Diff: http://git.reviewboard.kde.org/r/111184/diff/ > > > Testing > ------- > > > Thanks, > > Albert Vaca Cintora > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
