-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review35814
-----------------------------------------------------------
Ship it!
OK, so let's get this in then.
About file_unix.cpp: yes it's unix calls, but kde_file.h is a layer on top of
the unix system calls in order to hide the { 32 bit | 64 bit transitional | 64
bit final } versions of these system calls. It's that layer that I'd like to
remove (to avoid a central dependency on kde_file.h). On the other hand, if you
port everything else away from kde_file.h, I have no objection to it moving
together with kio_file (it kind of make sense to use lowlevel file stuff in
kio_file itself, for performance reasons or for special needs like suid/sgid).
kioslave/file/file.cpp
<http://git.reviewboard.kde.org/r/110988/#comment26255>
coding style: no spaces inside parenthesis (same in a few other places).
- David Faure
On July 9, 2013, 9:26 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110988/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 9:26 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Ports away kioslave/file from unix/kde specific calls to QFile calls
>
>
> Diffs
> -----
>
> kioslave/file/file.h 93aeef4
> kioslave/file/file.cpp 6b8b268
> kioslave/file/file_unix.cpp 8b92e06
>
> Diff: http://git.reviewboard.kde.org/r/110988/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
