----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111456/#review35828 -----------------------------------------------------------
kdeui/util/kcrash.h <http://git.reviewboard.kde.org/r/111456/#comment26271> Indentation should be fixed for that block. Also you probably want a regular comment not an apidox one here, and you should move that in kcrash.cpp it's not part of the API. kdeui/util/kcrash.h <http://git.reviewboard.kde.org/r/111456/#comment26273> No need to insert an extra line here. - Kevin Ottens On July 8, 2013, 9:32 p.m., Benjamin Port wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111456/ > ----------------------------------------------------------- > > (Updated July 8, 2013, 9:32 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Create KCrash framework > > Copy/Paste struct from klauncher_cmds to kcrash and rename it to avoid > conflict > > > Diffs > ----- > > kded/CMakeLists.txt 6283135 > kdeui/CMakeLists.txt c7dd8c2 > kdeui/util/config-strlcpy.h.cmake > kdeui/util/kcrash.h f0c92f8 > kdeui/util/kcrash.cpp 2e36c03 > kdeui/util/strlcpy-fake.c e75cae3 > kinit/CMakeLists.txt 52c132c > kinit/kinit.cpp d95f3a4 > kio/CMakeLists.txt 1a3e683 > staging/CMakeLists.txt 3832396 > staging/kcrash/CMakeLists.txt PRE-CREATION > staging/kcrash/KCrashConfig.cmake.in PRE-CREATION > staging/kcrash/src/CMakeLists.txt PRE-CREATION > staging/kcrash/src/config-kcrash.h.cmake PRE-CREATION > staging/kde4support/autotests/CMakeLists.txt d179a1c > staging/kde4support/src/CMakeLists.txt c30e5f5 > > Diff: http://git.reviewboard.kde.org/r/111456/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Port > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel