----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36841 -----------------------------------------------------------
staging/kservice/tools/desktoptojson/kconfigtojson.h <http://git.reviewboard.kde.org/r/111689/#comment27174> maybe place the & and ** at the argument name to be consistent with other arguments? staging/kservice/tools/desktoptojson/kconfigtojson.cpp <http://git.reviewboard.kde.org/r/111689/#comment27176> Maybe use QStringLiteral? I.e. try to make it build with NO_CAST_FROM_ASCII? staging/kservice/tools/desktoptojson/kconfigtojson.cpp <http://git.reviewboard.kde.org/r/111689/#comment27175> different style in & placement in header/source - Kevin Krammer On July 30, 2013, 7:45 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111689/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 7:45 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Small program which takes a .desktop file and converts it to json. This is > useful to convert plugins which have their metadata in .desktop files (i.e. > all KDE plugins) to Qt's new plugin system. > > > Diffs > ----- > > staging/kservice/tools/CMakeLists.txt PRE-CREATION > staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION > staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION > staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION > staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111689/diff/ > > > Testing > ------- > > Converted metadata of several plugins and used them from QPluginLoader -- > works. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel