----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111834/#review36964 -----------------------------------------------------------
This review has been submitted with commit 0caf023573326992d1fcfe9dc5980d720209fe8f by Aleix Pol to branch frameworks. - Commit Hook On Aug. 1, 2013, 3:23 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111834/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 3:23 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > The class still was in kdeui so it had to be moved, after discussing with > ervin, it seemed like it's a good place for the function to be. > > After all, it's just a helper function, we can always (hope to) instantiate > the help using QDesktopServices::openUrl() > > > Diffs > ----- > > kdeui/CMakeLists.txt 5cbcfb0 > staging/xmlgui/src/CMakeLists.txt 255960f > staging/xmlgui/src/khelpclient.h e5f9946 > staging/xmlgui/src/khelpclient.cpp dda0b13 > > Diff: http://git.reviewboard.kde.org/r/111834/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
