----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111844/ -----------------------------------------------------------
(Updated Aug. 3, 2013, 5:11 p.m.) Review request for KDE Frameworks and Dawit Alemayehu. Changes ------- Make better use of KIO to simplify the new codebase: - uses stored alternatives when possible, this way we don't need a separate object to keep track of the data. - enable redirection in KIO::SimpleJob and use the KIO::SimpleJob::url to know where we ended up. This lets us remove the dirty ugly class we had, I still have no idea if this works though... Description ------- Forgot to port this one, it was the complex one to change. Since it needs to gather some data, it uses a helper class that does so, for data and for the final url. Diffs (updated) ----- staging/kio/src/widgets/accessmanager.cpp 7120226 Diff: http://git.reviewboard.kde.org/r/111844/diff/ Testing ------- I don't know if there's a test for the access manager... Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
