> On Aug. 23, 2013, 12:39 a.m., Aleix Pol Gonzalez wrote: > > You can use "git diff -M80%" instead of --find-copies-harder, then > > reviewboard doesn't complain. The semantics are a bit different but it will > > work for you, hopefully. > > > > Cheers!
It doesn't :( Without --find-copies-harder there isn't information [1] about copied file and RR thinks that whole file was added. [1] copy from staging/frameworkintegration/src/kstyle/kstyle.cpp copy to staging/kde4support/src/kdeui/k4style.cpp index 63506476..563aa81 100644 - Wojciech ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112217/#review38393 ----------------------------------------------------------- On Aug. 22, 2013, 11:34 p.m., Wojciech Kapuscinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112217/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 11:34 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > kdelibs_cleanup task: KStyle 1/3: Copy KStyle as K4Style in KDE4Support > > I cannot upload patch generated with --find-copies-harder (it works if file > was moved but not when copied) so I attached patch with --find-copies-harder > > > Diffs > ----- > > KDE5PORTING.html bbc1c41 > staging/kde4support/src/CMakeLists.txt ba56061 > staging/kde4support/src/kdeui/k4style.h PRE-CREATION > staging/kde4support/src/kdeui/k4style.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112217/diff/ > > > Testing > ------- > > it builds and tests looks OK > > > File Attachments > ---------------- > > patch generated with --find-copies-harder > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/k4style.patch > > > Thanks, > > Wojciech Kapuscinski > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
