----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112282/#review38581 -----------------------------------------------------------
staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp <http://git.reviewboard.kde.org/r/112282/#comment28527> I'd prefer keeping the "else" construct here. staging/frameworkintegration/src/platformtheme/khintssettings.cpp <http://git.reviewboard.kde.org/r/112282/#comment28529> Remove or move just before the QDir include. staging/frameworkintegration/src/platformtheme/khintssettings.cpp <http://git.reviewboard.kde.org/r/112282/#comment28528> Clean that up since we're at it, would make the QDebug include useless if I'm not mistaken. - Kevin Ottens On Aug. 26, 2013, 12:58 a.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112282/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2013, 12:58 a.m.) > > > Review request for KDE Frameworks and Kevin Ottens. > > > Description > ------- > > With all the updating logic, palette will become complex, so we better > move it into another class before starting to make KdePlatformTheme > bloated. > > Also makes more sense when creating unittest. > > > Diffs > ----- > > staging/frameworkintegration/autotests/CMakeLists.txt 25fd48e > staging/frameworkintegration/src/platformtheme/CMakeLists.txt 4130e33 > staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h 1a5c057 > staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 31d5479 > staging/frameworkintegration/src/platformtheme/khintssettings.h > PRE-CREATION > staging/frameworkintegration/src/platformtheme/khintssettings.cpp > PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112282/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
