----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112449/#review39178 -----------------------------------------------------------
staging/kunitconversion/src/converter.h <http://git.reviewboard.kde.org/r/112449/#comment28906> When used from apps, doesn't this risk including a value.h from another subdir, like e.g. kjs? I think kunitconversion/value.h is much better. For this to compile after your move, you can still get that if you generate local forwarding headers like I do in kio. - David Faure On Sept. 2, 2013, 2:12 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112449/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 2:12 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Move all the files from kunitconversion/src/kunitconversion to > kunitconversion/src, makes sure everything compiles > > > Diffs > ----- > > staging/kunitconversion/autotests/categorytest.h e065e4a > staging/kunitconversion/autotests/categorytest.cpp 5bf2ef8 > staging/kunitconversion/autotests/convertertest.h 977e816 > staging/kunitconversion/autotests/convertertest.cpp 085c368 > staging/kunitconversion/autotests/valuetest.h e87e527 > staging/kunitconversion/src/CMakeLists.txt eff454a > staging/kunitconversion/src/converter.h 6be08e4 > staging/kunitconversion/src/kcurrencycode.h 8753ec4 > > Diff: http://git.reviewboard.kde.org/r/112449/diff/ > > > Testing > ------- > > builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
