----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112457/#review39242 -----------------------------------------------------------
Ship it! just one thing staging/kdoctools/config-kdoctools.h.cmake <http://git.reviewboard.kde.org/r/112457/#comment28940> It's a bit strange to do that here. See below. staging/kdoctools/src/meinproc.cpp <http://git.reviewboard.kde.org/r/112457/#comment28939> I'd write exe = QStringLiteral(XMLLINT) instead of putting the QStringLiteral in the config-foo.h file (which doesn't know how it's going to be used). The preprocessor will replace the macro with the literal so QStringLiteral is correct here. - David Faure On Sept. 2, 2013, 4:42 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112457/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 4:42 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Start using DocBook*cmake modules from ECM (pending to be solved). > Properly construct strings for KDocTools, making sure QStringLiteral & > friends are used. > > > Diffs > ----- > > staging/kdoctools/config-kdoctools.h.cmake f2fe22c > staging/kdoctools/src/CMakeLists.txt de82d4d > staging/kdoctools/src/docbookl10nhelper.cpp abd980c > staging/kdoctools/src/meinproc.cpp 1c72881 > staging/kdoctools/src/meinproc_common.cpp 18f7346 > staging/kdoctools/src/meinproc_simple.cpp ad34fb9 > staging/kdoctools/src/xslt.cpp 2256bf6 > > Diff: http://git.reviewboard.kde.org/r/112457/diff/ > > > Testing > ------- > > Builds, KDocTools has no tests. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
