----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112455/#review39264 -----------------------------------------------------------
Much better. One bug though. kfile/kdirselectdialog.cpp <http://git.reviewboard.kde.org/r/112455/#comment28957> Err... did you mean if (!job->exec())? (no space in (...) in new code, btw) kfile/kdirselectdialog.cpp <http://git.reviewboard.kde.org/r/112455/#comment28956> return path.isEmpty() ? url : QUrl::fromLocalFile(path); would save 6 lines and increase readability (IMHO; feel free to disagree :) ). - David Faure On Sept. 3, 2013, 1:46 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112455/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 1:46 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Ported all remaining usages of KIO::NetAccess to Job+exec. > > In one case I have added a new method in the Private because the code looked > better. > > > Diffs > ----- > > kfile/kdiroperator.cpp 72789ae > kfile/kdirselectdialog.cpp 92cff2f > kfile/kfileplacesmodel.cpp e854059 > kfile/kfilewidget.cpp f668039 > kfile/knewfilemenu.cpp 5e768b8 > > Diff: http://git.reviewboard.kde.org/r/112455/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
