----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39293 -----------------------------------------------------------
You may consider renaming the variables from ALLUPPERCASE_SOMETHING to CamelCase_SOMETHING, i.e. to DocBookXSL_* and DocBookXML_*, to follow the cmake guidelines for naming variables better. When doing that, please add that change here: http://techbase.kde.org/Development/ECM_SourceIncompatChanges - Alexander Neundorf On Sept. 3, 2013, 12:45 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112451/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 12:45 p.m.) > > > Review request for Build System, KDE Frameworks and Luigi Toscano. > > > Description > ------- > > When trying to properly split KDocTools I saw that FindDocBookXML.cmake and > FindDocBookXSL.cmake were at an attic directory that was not being processed. > > This patch adds the directory to be used and fixes the installation so it > works. It looks weird to me that this was not the case and maybe I'm missing > something. Please tell me if that's the case. > > > Diffs > ----- > > attic/modules/FindDocBookXML.cmake > attic/modules/FindDocBookXSL.cmake > > Diff: http://git.reviewboard.kde.org/r/112451/diff/ > > > Testing > ------- > > Installs and seems to work. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
