----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112495/ -----------------------------------------------------------
Review request for KDE Frameworks. Description ------- Removes the remove_definitions(..) from cmake, no code changes needed. KCrash however has no tests, I'm not sure how to test it properly (if someone can give me ideas, I'll try writing such tests). Diffs ----- staging/CMakeLists.txt 3e4ec3a staging/kcrash/CMakeLists.txt ce926ec staging/kcrash/KCrashConfig.cmake.in staging/kcrash/src/CMakeLists.txt 5dab9be staging/kcrash/src/config-kcrash.h.cmake staging/kcrash/src/config-strlcpy.h.cmake staging/kcrash/src/kcrash.h staging/kcrash/src/kcrash.cpp staging/kcrash/src/strlcpy-fake.c tier2/CMakeLists.txt bd5ea8c Diff: http://git.reviewboard.kde.org/r/112495/diff/ Testing ------- Builds ok. Thanks, Martin Klapetek
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
