> On Sept. 1, 2013, 8:31 a.m., David Faure wrote: > > tier1/sonnet/src/ui/spellcheckdecorator.h, line 42 > > <http://git.reviewboard.kde.org/r/112281/diff/2/?file=185151#file185151line42> > > > > Missing documentation (in particular about the ownership being > > transferred to the decorator) .... hmm, do we really want that, btw? I > > thought the highlighter was also going to be used elsewhere? > > [I'm lacking context a little bit, for a full understanding] > > David Edmundson wrote: > We want to avoid the code duplication in KTextEdit which has the same > code for making a context menu as the SpellCheckDecorator installs. That has > a setHighlighter() method so naturally in order to re-use the decorator I > need to be able to set a highlighter here. > > Relevant other patch is here: https://git.reviewboard.kde.org/r/112283/ > (not published because I need to get this in first.. and due to changes I now > need to rewrite that other patch anyway).
I understand the need for a setter. My question is about ownership: should the decorator really own (and therefore delete) that highlighter? Won't that lead to double deletions if the textedit also owns it? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review39051 ----------------------------------------------------------- On Sept. 6, 2013, 5:53 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112281/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 5:53 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Allow setting a custom highlighter on the spell check decorator > > -- > > This is needed in order to use this code from inside KTextEdit which allows > setting a custom highlighter. > This will also be useful for anyone wanting to subclass Sonnet::Highlighter > on a QTextEdit. > > > Diffs > ----- > > tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d > tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 > > Diff: http://git.reviewboard.kde.org/r/112281/diff/ > > > Testing > ------- > > None - my KF5 setup has no dictionaries installed. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
