----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112560/ -----------------------------------------------------------
(Updated Sept. 9, 2013, 3:50 p.m.) Review request for KDE Frameworks. Changes ------- I've been reviewing the patch, I realized that it doesn't make much sense to leave the doBeep method anymore. This patch removes it and all its uses. Description ------- Drop KNotifications dependency from KCompletion. Reasons: - Its not used in KDE4 - It creates noise - It bumps KCompletion from tier2 to tier3 I know I already sent an e-mail about it, but it seemed to me that a review request would be more welcome. Diffs (updated) ----- staging/kcompletion/src/CMakeLists.txt 1300ab5 staging/kcompletion/src/kcompletion.h 682a058 staging/kcompletion/src/kcompletion.cpp bcd220a staging/kcompletion/src/khistorycombobox.cpp fe955a2 Diff: http://git.reviewboard.kde.org/r/112560/diff/ Testing ------- builds, tests pass. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
