> On Sept. 12, 2013, 9:06 p.m., Chusslove Illich wrote: > >
> [: Aleix Pol Gonzalez :] > It's not really adding much value here, so I'd say we can drop it. I agree that none of these strings seem like they would need ki18n's specialties. (I can't comment on what the proper form of tr() is for replacement.) - Chusslove ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689/#review39914 ----------------------------------------------------------- On Sept. 12, 2013, 4:47 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112689/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2013, 4:47 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > It's not really adding much value here, so I'd say we can drop it. > > I'm not sure that tr() is as well the correct replacement for i18nc(), can > anybody confirm? > > > Diffs > ----- > > staging/kcompletion/src/CMakeLists.txt dd9d99c > staging/kcompletion/src/kcombobox.cpp 8a73a1b > staging/kcompletion/src/khistorycombobox.cpp 2e53bd9 > staging/kcompletion/src/klineedit.cpp 76ef377 > > Diff: http://git.reviewboard.kde.org/r/112689/diff/ > > > Testing > ------- > > builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
