On Sunday 15 September 2013, Aleix Pol wrote: > On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly <steve...@gmail.com> wrote: > > Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > > > > once > > > > > in the root CMakeLists.txt. Actually this should be the only file with > > > "find_package" calls. > > > > Why? What is the problem with having a find_package in src? > > > > Thanks, > > > > Steve. > > > > > > _______________________________________________ > > Kde-frameworks-devel mailing list > > Kde-frameworks-devel@kde.org > > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > > Well, it's good to have all the finders in the same place, to have a place > where to look when we need to see what a module works on. > > That's of course debatable, but I'd like to push for this kind of > uniformity. Make things as the user/developer would expect them to be.
I agree with that. For plugins it may be not as clear. Still, if a plugin needs some additional package, the top level CMakeLists.txt can search for it and enable the plugin depending on whether it was found or not. Alex _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
