----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112796/#review40323 -----------------------------------------------------------
tier1/kguiaddons/tests/CMakeLists.txt <http://git.reviewboard.kde.org/r/112796/#comment29759> But now it's kguiaddons (a tier1) that doesn't build standalone (with tests enabled), because it needs KConfigWidgets which is in a higher tier. Can you look further into kcolorspaces.h? Should it be installed? If not, it should be called _p.h. Can the test use higher-level public API instead of an internal header? - David Faure On Sept. 18, 2013, 4:27 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112796/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 4:27 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > This is required for kconfigwidgets to build standalone because > kcolorutilsdemo.cpp includes kcolorspaces.h, which is part of kguiaddons but > not installed. > > > Diffs > ----- > > staging/kconfigwidgets/tests/CMakeLists.txt bc52bc1 > staging/kconfigwidgets/tests/kcolorutilsdemo.h 09e867a > staging/kconfigwidgets/tests/kcolorutilsdemo.cpp 940569e > staging/kconfigwidgets/tests/kcolorutilsdemo.ui c6604fd > staging/kconfigwidgets/tests/kimageframe.h d521cb5 > staging/kconfigwidgets/tests/kimageframe.cpp 60a5e9d > tier1/kguiaddons/tests/CMakeLists.txt 4d91ed8 > tier1/kguiaddons/tests/kcolorutilsdemo.h PRE-CREATION > tier1/kguiaddons/tests/kcolorutilsdemo.cpp PRE-CREATION > tier1/kguiaddons/tests/kcolorutilsdemo.ui PRE-CREATION > tier1/kguiaddons/tests/kimageframe.h PRE-CREATION > tier1/kguiaddons/tests/kimageframe.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112796/diff/ > > > Testing > ------- > > Still builds, kcolorutilsdemo runs correctly. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel