> On Sept. 19, 2013, 7:48 a.m., David Faure wrote: > > staging/kemoticons/src/core/kemoticons.cpp, line 110 > > <http://git.reviewboard.kde.org/r/112808/diff/1/?file=190507#file190507line110> > > > > This test is already done internally in QFSW, remove it from here.
But then, it keeps outputting that it's already in, doesn't it? At least on Qt4 it does. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/#review40325 ----------------------------------------------------------- On Sept. 18, 2013, 10:26 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112808/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 10:26 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port away from KDirWatch in KEmoticons (prior to splitting) > > > Diffs > ----- > > staging/kemoticons/src/core/CMakeLists.txt > 0e79eaae60dfd5cd5e0c5f6848b86dbb90c0c818 > staging/kemoticons/src/core/kemoticons.cpp > 5f6a23ec606b3c6dceac2e01a280413e6899a59b > > Diff: http://git.reviewboard.kde.org/r/112808/diff/ > > > Testing > ------- > > It builds and installs correctly. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel