----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112909/ -----------------------------------------------------------
Review request for KDE Frameworks and John Layt. Description ------- Most of the printing features are now part of Qt 5.2 and basically only 4 features are left: - Page Label - Page Border - Mirror Pages - (Advanced) Job Options - Server-side paging I've dropped Job Options as it was quite terrible way to edit/pass CUPS options directly. Server-side paging is actually just a convenient feature as with QPrintDialog, apps that can't do paging themselves need 2 lines of code to set the printing dialog up, thanks to KDEPrintDialog only one line is needed. The rest I've put under Page Options tab in the print dialog. To be honest I don't think they are that useful (or used, even) but we have the code and CUPS support already. If these options were to be dropped however, I'd drop the whole KDE Print support then as it would become just a convenient wrapper around QPrintDialog. Diffs ----- staging/kde4attic/src/CMakeLists.txt 4acf1b6 staging/kde4attic/src/kcupsoptionsjobwidget.ui 182b23e staging/kde4attic/src/kcupsoptionsjobwidget_p.cpp 3c7913d staging/kde4attic/src/kcupsoptionspageswidget.ui a68865d staging/kde4attic/src/kcupsoptionspageswidget_p.h ede67e6 staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 79c6834 staging/kde4attic/src/kcupsoptionssettingswidget_p.cpp 7b58a37 staging/kde4attic/src/kdeprintdialog.cpp 4722f4c Diff: http://git.reviewboard.kde.org/r/112909/diff/ Testing ------- Tested with Konsole5. Thanks, Martin Klapetek
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
