> On Sept. 25, 2013, 2:03 p.m., Aleix Pol Gonzalez wrote: > > Looks good to me, not adding the shipit because I'm clueless about > > superbuild. > > > > Why do we need to specify the dependencies from superbuild? Shouldn't they > > depend on the Config.cmake files?
You mean after "DEPENDS" ? Because the superbuild CMakeLists.txt has no information otherwise which sub-builds depend on which other sub-builds, so this information must be there to make sure e.g. tier1 libs are built before tier2 libs etc. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/#review40764 ----------------------------------------------------------- On Sept. 25, 2013, 12:54 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112932/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2013, 12:54 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > > Add missing find_packages to kunitconversion > > -- > > Update superbuild to include all tiered libraries > > (separate commits) > > superbuild dependencies were taken from the relevant CMake.in files, which > may or may not be correct. > > > Diffs > ----- > > tier3/kunitconversion/KUnitConversionConfig.cmake.in 7bbf71c > superbuild/CMakeLists.txt 86e3389 > > Diff: http://git.reviewboard.kde.org/r/112932/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
