Aurélien Gâteau wrote: >> ECM and Qt version bumps are not as much an issue as the cmake one. The >> ECM and Qt version deps are not as likely to change. > > I don't understand why you think specifying the cmake version is an issue: > it should be easy to update the template when this happens, isn't it?
Yes, I suppose. >> Simplify by putting NO_MODULE before REQUIRED and removing COMPONENTS: >> >>find_package(Qt5 ${REQUIRED_QT_VERSION} NO_MODULE REQUIRED Widgets) > > Done. Are you sure? The reviewboard shows otherwise. >> >> > if(NOT kdelibs_SOURCE_DIR) >> > find_package(KF5 5.0.0 REQUIRED MODULE COMPONENTS CMake Compiler >> > InstallDirs) # Required KF5 frameworks to build this framework >> >> I still think this stuff is odd. We're building KF5, yet we need to find >> KF5 to do so. > > This line is only used when building the framework outside of kdelibs, in > this case we are not building KF5. We use find_package(KF5) when building each KF5 framework, and when building the 'monolithic' (but temporary) kdelibs.git. Thanks, Steve. _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel