----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112943/#review40871 -----------------------------------------------------------
Ship it! Looks good, compiles so ship it. - Àlex Fiestas On Sept. 25, 2013, 6:03 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112943/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2013, 6:03 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Not much else, only some small adjustments to fit module constraints. > > Some dependencies could be cut in the future, but there's nothing obvious. > > > Diffs > ----- > > CMakeLists.txt eb1ea8c > kparts/AUTHORS > kparts/CMakeLists.txt 042b78f > kparts/COMMENTS > kparts/KPartsConfig.cmake.in > kparts/Mainpage.dox > kparts/autotests/CMakeLists.txt 4746ecb > kparts/autotests/openorsavequestion_unittest.cpp > kparts/autotests/parttest.h > kparts/autotests/parttest.cpp > kparts/src/CMakeLists.txt > kparts/src/browserextension.h > kparts/src/browserextension.cpp > kparts/src/browserinterface.h > kparts/src/browserinterface.cpp > kparts/src/browseropenorsavequestion.h > kparts/src/browseropenorsavequestion.cpp > kparts/src/browserrun.h > kparts/src/browserrun.cpp > kparts/src/browserrun_p.h > kparts/src/browserview.desktop > kparts/src/event.h > kparts/src/event.cpp > kparts/src/fileinfoextension.h > kparts/src/fileinfoextension.cpp > kparts/src/historyprovider.h > kparts/src/historyprovider.cpp > kparts/src/htmlextension.h > kparts/src/htmlextension.cpp > kparts/src/kpart.desktop > kparts/src/krop.desktop > kparts/src/krwp.desktop > kparts/src/listingextension.h > kparts/src/listingextension.cpp > kparts/src/mainwindow.h > kparts/src/mainwindow.cpp > kparts/src/part.h > kparts/src/part.cpp > kparts/src/partmanager.h > kparts/src/partmanager.cpp > kparts/src/plugin.h > kparts/src/plugin.cpp > kparts/src/scriptableextension.h > kparts/src/scriptableextension.cpp > kparts/src/scriptableextension_p.h > kparts/src/statusbarextension.h > kparts/src/statusbarextension.cpp > kparts/src/textextension.h > kparts/src/textextension.cpp > kparts/tests/CMakeLists.txt 66845be > kparts/tests/README > kparts/tests/kpartstest_part1.rc > kparts/tests/kpartstest_part2.rc > kparts/tests/kpartstest_shell.rc > kparts/tests/normalktm.h > kparts/tests/normalktm.cpp > kparts/tests/notepad.h > kparts/tests/notepad.cpp > kparts/tests/notepad.desktop > kparts/tests/notepadpart.rc > kparts/tests/openorsavequestion.cpp > kparts/tests/parts.h > kparts/tests/parts.cpp > kparts/tests/partviewer.h > kparts/tests/partviewer.cpp > kparts/tests/partviewer_shell.rc > kparts/tests/plugin_foobar.rc > kparts/tests/plugin_spellcheck.h > kparts/tests/plugin_spellcheck.cpp > kparts/tests/plugin_spellcheck.rc > kparts/tests/testmainwindow.h > kparts/tests/testmainwindow.cpp > tier3/CMakeLists.txt 5ac107a > > Diff: http://git.reviewboard.kde.org/r/112943/diff/ > > > Testing > ------- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
