> On Sept. 30, 2013, 2:01 p.m., Aleix Pol Gonzalez wrote: > > staging/kprintutils/CMakeLists.txt, line 30 > > <http://git.reviewboard.kde.org/r/112964/diff/1/?file=192865#file192865line30> > > > > Why are you removing these?
They have no effect on the code as the code compiles without them, so they are useless. Also I think the code should compile without any definitions being removed. > On Sept. 30, 2013, 2:01 p.m., Aleix Pol Gonzalez wrote: > > staging/kprintutils/CMakeLists.txt, line 15 > > <http://git.reviewboard.kde.org/r/112964/diff/1/?file=192865#file192865line15> > > > > Only half our modules are like this so far, should we add this as a KF5 > > module requirement? Could be, it's only temporary to allow building everything in one dir anyway and it should go away once everything is splitted for real. Imho it's easier in later stage to just remove one "if" line than to investigate what packages need to be found. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41027 ----------------------------------------------------------- On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112964/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2013, 9:15 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > ...before splitting. > > > Diffs > ----- > > staging/kprintutils/CMakeLists.txt 28ce872 > staging/kprintutils/KPrintUtilsConfig.cmake.in f281555 > > Diff: http://git.reviewboard.kde.org/r/112964/diff/ > > > Testing > ------- > > Still builds. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
