> On Oct. 2, 2013, 4:47 p.m., Aleix Pol Gonzalez wrote:
> > I like the idea of being more specific about the return value, but isn't
> > this going to break source compatibility?
No because it is OK to assign an enum to an int, so this code:
int result = KMessageBox::warningContinueCancel(...)
will still work.
The only tricky part is KMessageBox::createKMessageBox(). See my email about it
on kde-frameworks-devel.
- Aurélien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113050/#review41120
-----------------------------------------------------------
On Oct. 2, 2013, 4:43 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113050/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 4:43 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Use enum for KMessageBox return types instead of int.
>
>
> Diffs
> -----
>
> staging/kde4support/src/kdeui/kmessagebox_queued.cpp 00e9eb0
> tier1/kwidgetsaddons/src/kmessagebox.h 4d1306b
> tier1/kwidgetsaddons/src/kmessagebox.cpp d974cd6
>
> Diff: http://git.reviewboard.kde.org/r/113050/diff/
>
>
> Testing
> -------
>
> Builds, tests pass.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
