----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113073/#review41165 -----------------------------------------------------------
Ship it! - David Edmundson On Oct. 3, 2013, 9:32 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113073/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2013, 9:32 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > KColorSpaces is private, suffix its header with "_p" and don't export code > from it. > > > Diffs > ----- > > tier1/kguiaddons/src/lib/colors/kcolorspaces.h f21631a > tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp 8808278 > tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h PRE-CREATION > tier1/kguiaddons/src/lib/colors/kcolorutils.cpp 2fa1960 > > Diff: http://git.reviewboard.kde.org/r/113073/diff/ > > > Testing > ------- > > Builds, tests pass. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
