-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113091/#review41200
-----------------------------------------------------------



src/BookmarkHandler.h
<http://git.reviewboard.kde.org/r/113091/#comment30229>

    Don't forget the new currentIcon too.



src/BookmarkHandler.cpp
<http://git.reviewboard.kde.org/r/113091/#comment30228>

    Just view->url().


- David Faure


On Oct. 4, 2013, 9:11 a.m., Casian Andrei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113091/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 9:11 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Build fails following some changes in kdelibs.
> 
> Quick fix!
> 
> 
> Diffs
> -----
> 
>   src/BookmarkHandler.h 04e988d 
>   src/BookmarkHandler.cpp 7a54b17 
> 
> Diff: http://git.reviewboard.kde.org/r/113091/diff/
> 
> 
> Testing
> -------
> 
> Not tested, because of some link issue with Ki18n...
> 
> Should work though.
> 
> 
> Thanks,
> 
> Casian Andrei
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to