----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/#review41573 -----------------------------------------------------------
Ship it! So time_t does exist on Windows? Very interesting, I really thought it didn't. Proving again that blind-porting to Windows is a bad idea :) Thank you for doing the real thing i.e. actually trying it out on Windows. - David Faure On Oct. 11, 2013, 5:25 p.m., Nicolás Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113196/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 5:25 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > kdirwatch: include correct header for time_t and ino_t. > > We were including sys/time.h and sys/param.h, but Windows doesn't have > them, and POSIX says those types are defined in sys/types.h. > > This doesn't fix the build on Windows, but it's a step. > > > Diffs > ----- > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h > 77c7d6d1f83f0c984043ed1c7e3a83a2e824d0c7 > > Diff: http://git.reviewboard.kde.org/r/113196/diff/ > > > Testing > ------- > > Still builds and passes tests on Linux/gcc. > > Still fails to build on Windows/MSVC2010 but not for this reason :) > > > Thanks, > > Nicolás Alvarez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
