----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/#review42587 -----------------------------------------------------------
Ship it! Looks fine to me and is aligned with prior discussions. - Kevin Ottens On Oct. 28, 2013, 6:26 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113483/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 6:26 p.m.) > > > Review request for KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Copy KDE4 macro to install all icons in the current source dir > > > Diffs > ----- > > modules/ECMInstallIcons.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113483/diff/ > > > Testing > ------- > > Tried using it from within khtml. It all compiled successfully however I > could not test icon installation as khtml was already broken (see other email > to KF ML) > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
