----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42596 -----------------------------------------------------------
This review has been submitted with commit 73048bfeb8df80146975561c9100d40ccd13cd1d by Alex Merry to branch frameworks. - Commit Hook On Oct. 25, 2013, 2:08 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113430/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 2:08 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > This is a series of commits: > > > warnings--: parentheses around '&&' within '||' > > > Fix a couple of warnings inadventently caused by 139a09da > > > Use a better hack for dealing with gperf's unhelpful inlining > > gperf (in ANSI-C mode) attempts to inline functions in gnu90 mode, which > *only* generates inline versions. This causes linker errors if the > compiler decides not to use inlining. > > Previously, there was a hack (claiming to prevent warnings) that > disabled __inline keyword, which fixed the linking issue but caused > another warning (about ignored attributes) to be emitted because the > __gnu_inline__ attribute was still there, and that doesn't work without > one of the normal inline keywords. > > This version leaves __inline alone, but prevents the use of > __gnu_inline__. > > > Use KHTML_NO_EXPORT on the decl (not def) of tagPriorityArray > > Visibility attributes only work on declarations, not on definitions. > > > Remove virtual modifier from signal > > A virtual signal makes no sense. > > > Diffs > ----- > > khtml/src/html/dtd.cpp 9cfa345af618861a9b8ddf9a93dd180c9a15c6d7 > khtml/src/html/dtd.h 1e04e58b356c5d0ece23f8fc78cffdc6cf64817c > khtml/src/css/parser.y e24d5f46e27c686fa855feee27dbe2dbf39108cb > khtml/src/html/htmlparser.cpp 6c23dd5b5a2a1e567adc8cfa0233e10838cf3451 > khtml/src/rendering/render_canvasimage.cpp > 346a65491e459c3d8f1c731340ff5a6ae33b35f1 > khtml/src/rendering/render_inline.cpp > 84e07eab5604e4882fd816826b6e59c317c53805 > tier1/itemmodels/src/kselectionproxymodel.cpp > c7ded3f8c54eba0afa1974ddb67972eddf7d7f1a > tier1/solid/src/solid/backends/udev/udevbutton.h > 39eb6683fc611dfff5b6fef69e66ab709238e889 > > Diff: http://git.reviewboard.kde.org/r/113430/diff/ > > > Testing > ------- > > Builds, tests pass. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel