----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/#review42659 -----------------------------------------------------------
This review has been submitted with commit 89d2b298dfe4b97b2e51d55bb85f96a1e803714e by David Gil to branch frameworks. - Commit Hook On Oct. 24, 2013, 9:54 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113426/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 9:54 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Adjust API in KEmoticons framework: createNew method > > -To make KEmoticons API more consistent, deprecate > KEmoticonsProvider::createNew() > and prefer newTheme() instead, as it appears in KEmoticonsTheme. That way, > we have loadTheme(), saveTheme() and newTheme(). > -Adjust plugins. > -Before the cleanup, KEmoticonsTheme was calling > KEmoticonsProvider::createNew(), > which was empty. Therefore, I deprecate it and advice subclassing > KEmoticonsProvider. > > > Diffs > ----- > > KDE5PORTING.html ceff2fa13e4a666939dd0a1bb63e967504c31c07 > staging/kemoticons/src/core/kemoticons.cpp > 43dac6517b77a0d0040912958fe76687b475d85c > staging/kemoticons/src/core/kemoticonsprovider.h > 2ec0de8d1dfb846188bd458b49a4028fee115431 > staging/kemoticons/src/core/kemoticonsprovider.cpp > 7374966c65922c3e7a5be881c198a8f8f52fee29 > staging/kemoticons/src/core/kemoticonstheme.h > 25fc29453535d7e73f4e2d0752ce3f989c83fa96 > staging/kemoticons/src/core/kemoticonstheme.cpp > e54d015e7f0f866d199d8eed7863fafd28576c13 > staging/kemoticons/src/providers/adium/adium_emoticons.h > 01d89e13834c345765e696d66560071dc10291af > staging/kemoticons/src/providers/adium/adium_emoticons.cpp > e6719d112a14478bdfd7f8c47633c18108a5633a > staging/kemoticons/src/providers/kde/kde_emoticons.h > 0738b79dcf734b7904e061b5eb41807ccaf443ff > staging/kemoticons/src/providers/kde/kde_emoticons.cpp > a99c6d84f5ab7e0e2f41027c37a97f170333dca8 > staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h > a51b736f7702d7af1f1367dd1f13271647212fee > staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp > 7596e30e8e5153185a3dd365858567c69477ff4a > staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h > 4ba706f519cebedaa6c9c3f2f02331e85745e89a > staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp > afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809 > > Diff: http://git.reviewboard.kde.org/r/113426/diff/ > > > Testing > ------- > > Builds. Tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel