----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/ -----------------------------------------------------------
(Updated Oct. 31, 2013, 10:15 a.m.) Status ------ This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description ------- Instead of implementing queueing in KDialogJobUiDelegate, I'm making use of QErrorMessage which has queueing built into it. We also inherit the "Show this message again" checkbox, but I have a review request here https://codereview.qt-project.org/67243 that adds new API to Qt 5.3 , so we can hide that once 5.3 comes out ( if that makes sense ). Diffs ----- staging/kjobwidgets/src/kdialogjobuidelegate.h 5d17a4d staging/kjobwidgets/src/kdialogjobuidelegate.cpp 29c2bae Diff: http://git.reviewboard.kde.org/r/113158/diff/ Testing ------- Tested by writing a application that uses KIO to fetch an invalid site url. Dialog pops up just fine. Thanks, Rohan Garg
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
