> On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps?
The default depth is 30 when you're using the NVIDIA driver and the monitor supports 30 bits. This is the reason why it's important. The X server can be told to use a 30 bit visual even when the monitor only supports 24 bits by starting it with -depth 30. But this isn't supported by all drivers. Note that the raster graphics system is completely broken when the default depth is 30 since Qt assumes that any depth >= 24 means 8 bits per channel. - Fredrik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review42568 ----------------------------------------------------------- On Nov. 4, 2013, 8:14 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112755/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 8:14 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Implements the createPixmapFromHandle by getting the image for the pixmaps > and using it as either the Pixmap or the bitmap mask. > > > Diffs > ----- > > tier1/kwindowsystem/src/kxutils.cpp 33bd678 > tier1/kwindowsystem/src/kxutils_p.h 84d639b > tier1/kwindowsystem/tests/CMakeLists.txt 0060903 > tier1/kwindowsystem/tests/createpixmapfromhandletest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112755/diff/ > > > Testing > ------- > > Adjusted KWin to take this codepath and say thanks to Iceweasel for having a > mask > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
