----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113634/#review43041 -----------------------------------------------------------
Ship it! tier1/kcoreaddons/autotests/CMakeLists.txt <http://git.reviewboard.kde.org/r/113634/#comment31046> Pretty cool. I can't even imagine how one would do this with qmake. cmake FTW :) tier1/kcoreaddons/autotests/CMakeLists.txt <http://git.reviewboard.kde.org/r/113634/#comment31045> lowe -> lower tier1/kcoreaddons/autotests/ConfigureChecks.cmake <http://git.reviewboard.kde.org/r/113634/#comment31047> maybe add a delete watcher or a Q_UNUSED(watcher) to avoid a compiler warning confusing people in case of problems? - David Faure On Nov. 5, 2013, 10:51 a.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113634/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 10:51 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > KDirWatch can use different backends and we need to test them all, so > from now on we will be generating one test per each compiled backend. > > > Diffs > ----- > > tier1/kcoreaddons/autotests/CMakeLists.txt bf7d1a1 > tier1/kcoreaddons/autotests/ConfigureChecks.cmake PRE-CREATION > tier1/kcoreaddons/autotests/kdirwatch_unittest.cpp 585ff96 > > Diff: http://git.reviewboard.kde.org/r/113634/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
