> On Nov. 6, 2013, 12:26 a.m., Nicolás Alvarez wrote: > > I just tried this on Windows 7, MSVC 2010, 32-bit. The library itself > > compiles. The autotests ask for X11 headers though; it seems some of the > > autotests have to be disabled altogether on Windows. > > > > In addition, the only manual test doesn't work. What it's trying to do > > might be impossible on Windows, though... > > > > I also reviewed the patch, and didn't see anything wrong; but I'm also not > > confident enough to give a ship-it. Where are the Windows experts? :)
I didn't try running the tests yet, I only fixed the compiler errors since the fixes are (seem) obvious. Definitely need review by someone who knows more about Windows. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/#review43127 ----------------------------------------------------------- On Nov. 4, 2013, 9:33 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113631/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 9:33 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Allow compiling kwindowsystem on Windows > > > Diffs > ----- > > tier1/CMakeLists.txt 277b3f0 > tier1/kwindowsystem/CMakeLists.txt dc8fcae > tier1/kwindowsystem/src/CMakeLists.txt d9d141e > tier1/kwindowsystem/src/kkeyserver_win.h 6328f41 > tier1/kwindowsystem/src/kstartupinfo.h 39c2935 > tier1/kwindowsystem/src/kstartupinfo.cpp 402cc97 > tier1/kwindowsystem/src/kwindowinfo_win.cpp d392fe9 > tier1/kwindowsystem/src/kwindowsystem.h 0c6a930 > tier1/kwindowsystem/src/kwindowsystem_win.cpp 23a6616 > > Diff: http://git.reviewboard.kde.org/r/113631/diff/ > > > Testing > ------- > > Compiles (Windows 7, VS 2012 x64) > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
