> On Nov. 7, 2013, 2:16 p.m., Alex Merry wrote:
> > tier3/knotifyconfig/CMakeLists.txt, lines 20-35
> > <http://git.reviewboard.kde.org/r/113693/diff/2/?file=211413#file211413line20>
> >
> > Did I miss something? Why is CMake 3 relevant to these? KIO wasn't
> > exporting its dependencies to KIOConfig.cmake properly until recently, but
> > it should be doing so now.
That error you get it just by trying to find KIO. It's because the private
dependencies are looked up as well and the reason we have to list the private
dependencies.
CMake Error at /home/kde-devel/kde5/lib64/cmake/KIO/KIOConfig.cmake:31
(find_package):
Found package configuration file:
/home/kde-devel/kde5/lib64/cmake/KJobWidgets/KJobWidgetsConfig.cmake
but it set KJobWidgets_FOUND to FALSE so package "KJobWidgets" is
considered to be NOT FOUND. Reason given by package:
The following imported targets are referenced, but are missing:
KF5::KWidgetsAddons
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/#review43226
-----------------------------------------------------------
On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113693/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 1:07 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Add the dependencies of dependencies.
> Small fixes.
>
>
> Diffs
> -----
>
> superbuild/CMakeLists.txt 90688f6
> tier3/knotifyconfig/CMakeLists.txt 8be2ceb
> tier3/knotifyconfig/tests/CMakeLists.txt 385ff70
>
> Diff: http://git.reviewboard.kde.org/r/113693/diff/
>
>
> Testing
> -------
>
> Builds, installs, the test seems to work.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
