----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43351 -----------------------------------------------------------
Ship it! I think that's fine to keep the modules private, they're not used anywhere else AFAIK. We use kdnssd instead of avahi or such directly. If we find more users later on then we can put the effort to have them in ECM of course. - Kevin Ottens On Nov. 7, 2013, 1:30 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113657/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 1:30 p.m.) > > > Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen > Kelly. > > > Repository: kdelibs > > > Description > ------- > > Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when > building with DNSSD and factored out the Frameworks version. > > > Diffs > ----- > > cmake/modules/CMakeLists.txt 7910270 > cmake/modules/FindAvahi.cmake > cmake/modules/FindDNSSD.cmake 8604bd5 > tier2/dnssd/CMakeLists.txt 2cfcc40 > > Diff: http://git.reviewboard.kde.org/r/113657/diff/ > > > Testing > ------- > > 1. Configure with cmake > 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 > > Configures OK in both cases. Builds OK in case 1, does not build yet in case > 2. > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
